Remove unnecessary Result from return type in NamePreserver
#12358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
Jefffrey
approved these changes
Sep 6, 2024
Contributor
Jefffrey
left a comment
Jefffrey
left a comment
There was a problem hiding this comment.
Makes sense to me.
Should this be tagged with api change since technically NamePreserver and SavedName are technically exposed in the public API?
Contributor
I think you are right -- done! |
Dandandan
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow up of #12341
Rationale for this change
The
saveandrestorefunctions always returnOK, so theResultreturn type becomes redundant.What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
No