Skip to content

Remove unused dependencies and features #12808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Remove unused dependencies and features #12808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5aae868
Remove unused dependencies and features
jonahgao Oct 8, 2024
bcfb0bc
Update Cargo.lock
jonahgao Oct 8, 2024
63c7ce1
Remove regex and base64
jonahgao Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions datafusion-cli/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions datafusion/core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ math_expressions = ["datafusion-functions/math_expressions"]
parquet = ["datafusion-common/parquet", "dep:parquet"]
pyarrow = ["datafusion-common/pyarrow", "parquet"]
regex_expressions = [
"datafusion-physical-expr/regex_expressions",
"datafusion-optimizer/regex_expressions",
"datafusion-functions/regex_expressions",
]
serde = ["arrow-schema/serde"]
Expand Down
4 changes: 0 additions & 4 deletions datafusion/optimizer/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@ workspace = true
name = "datafusion_optimizer"
path = "src/lib.rs"

[features]
default = ["regex_expressions"]
regex_expressions = ["datafusion-physical-expr/regex_expressions"]

[dependencies]
arrow = { workspace = true }
async-trait = { workspace = true }
Expand Down
12 changes: 0 additions & 12 deletions datafusion/physical-expr/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,6 @@ workspace = true
name = "datafusion_physical_expr"
path = "src/lib.rs"

[features]
default = [
"regex_expressions",
"encoding_expressions",
]
encoding_expressions = ["base64", "hex"]
regex_expressions = ["regex"]

[dependencies]
ahash = { workspace = true }
arrow = { workspace = true }
Expand All @@ -51,23 +43,19 @@ arrow-buffer = { workspace = true }
arrow-ord = { workspace = true }
arrow-schema = { workspace = true }
arrow-string = { workspace = true }
base64 = { version = "0.22", optional = true }
chrono = { workspace = true }
datafusion-common = { workspace = true, default-features = true }
datafusion-execution = { workspace = true }
datafusion-expr = { workspace = true }
datafusion-expr-common = { workspace = true }
datafusion-functions-aggregate-common = { workspace = true }
datafusion-physical-expr-common = { workspace = true }
half = { workspace = true }
hashbrown = { workspace = true }
hex = { version = "0.4", optional = true }
indexmap = { workspace = true }
itertools = { workspace = true, features = ["use_std"] }
log = { workspace = true }
paste = "^1.0"
petgraph = "0.6.2"
regex = { workspace = true, optional = true }

[dev-dependencies]
arrow = { workspace = true, features = ["test_utils"] }
Expand Down
2 changes: 1 addition & 1 deletion datafusion/physical-plan/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ datafusion-common = { workspace = true, default-features = true }
datafusion-common-runtime = { workspace = true, default-features = true }
datafusion-execution = { workspace = true }
datafusion-expr = { workspace = true }
datafusion-functions-aggregate = { workspace = true }
datafusion-functions-aggregate-common = { workspace = true }
datafusion-functions-window-common = { workspace = true }
datafusion-physical-expr = { workspace = true, default-features = true }
Expand All @@ -69,6 +68,7 @@ rand = { workspace = true }
tokio = { workspace = true }

[dev-dependencies]
datafusion-functions-aggregate = { workspace = true }
Copy link
Contributor

@alamb alamb Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

As a follow on it would be great to remove this dependency too, but having it as a dev dependency is clearly better than a real dependency in my mind

Copy link
Member Author

@jonahgao jonahgao Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests require an aggregate function and will check the aggregation results, so not sure if it's possible to remove this dependency 🤔.

Copy link
Contributor

@alamb alamb Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can move that test into the sql_integration binary or something

Copy link
Member Author

@jonahgao jonahgao Oct 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that some tests call private methods, which means we can't move them to a different package. Perhaps we can try to address this in a subsequent PR.

rstest = { workspace = true }
rstest_reuse = "0.7.0"
tokio = { workspace = true, features = [
Expand Down