Skip to content

Conversation

@zhuliquan
Copy link
Contributor

Which issue does this PR close?

Closes #12930.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the functions Changes to functions implementation label Oct 15, 2024
@Omega359
Copy link
Contributor

ci failure looks unrelated to changes.

@zhuliquan
Copy link
Contributor Author

ci failure looks unrelated to changes.
yeah, I add test case for retring ci.😂

@Omega359
Copy link
Contributor

LGTM

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhuliquan for the contribution and @Omega359 and @findepi for the review

I also double checked that this is covered by @goldmedal 's very nice string_query.slt:

query BBBBBB
SELECT
CONTAINS(ascii_1, 'foo') as c1,
CONTAINS(ascii_1, ascii_2) as c2,
CONTAINS(ascii_1, NULL) as c3,
CONTAINS(unicode_1, unicode_2) as c4,
CONTAINS(unicode_1, NULL) as c5,
CONTAINS(unicode_1, '🔥') as c6
FROM test_basic_operator;
----
false false NULL true NULL true
false true NULL true NULL false
false true NULL true NULL false
NULL NULL NULL NULL NULL NULL

@alamb alamb merged commit 0e2023d into apache:main Oct 17, 2024
24 checks passed
@alamb
Copy link
Contributor

alamb commented Oct 17, 2024

🚀

@zhuliquan zhuliquan deleted the fix-contains branch October 17, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

functions Changes to functions implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

there is something wrong using contains udf

4 participants