Avoid Aliased Window Expr Enter Unreachable Code #14109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optimizer
alamb
approved these changes
Jan 14, 2025
| extract_partition_keys(window_func) | ||
| } else { | ||
| // window functions expressions are only Expr::WindowFunction | ||
| unreachable!() |
There was a problem hiding this comment.
maybe we can turn this into returning an internal error rather than a panic for safety
There was a problem hiding this comment.
Sounds good. I think there are few of those in the codebase and it would make a good first issue to remove these unreachable panics and replace them with internal errors. Let's create an issue for this
masonh22
pushed a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Sep 23, 2025
(cherry picked from commit fda500a)
masonh22
pushed a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Sep 24, 2025
(cherry picked from commit fda500a)
masonh22
pushed a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Sep 24, 2025
(cherry picked from commit fda500a)
avantgardnerio
pushed a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Oct 2, 2025
(cherry picked from commit fda500a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #14108.
Rationale for this change
Please see the issue.
What changes are included in this PR?
Aliased window expr is handled as if it is a normal window expr
Are these changes tested?
Yes, with an .slt test, which was failing before
Are there any user-facing changes?