Skip to content

fix: SortExec TopK OOM #17622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2025
Merged

fix: SortExec TopK OOM #17622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions datafusion/physical-plan/src/topk/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,19 +754,18 @@ impl TopKHeap {
return Ok((None, topk_rows));
}

// Indices for each row within its respective RecordBatch
let indices: Vec<_> = topk_rows
.iter()
.enumerate()
.map(|(i, k)| (i, k.index))
.collect();
// Collect the batches into a vec and store the "batch_id -> array_pos" mapping, to then
// build the `indices` vec below. This is needed since the batch ids are not continuous.
let mut record_batches = Vec::new();
let mut batch_id_array_pos = HashMap::new();
for (array_pos, (batch_id, batch)) in self.store.batches.iter().enumerate() {
record_batches.push(&batch.batch);
batch_id_array_pos.insert(*batch_id, array_pos);
}

let record_batches: Vec<_> = topk_rows
let indices: Vec<_> = topk_rows
.iter()
.map(|k| {
let entry = self.store.get(k.batch_id).expect("invalid stored batch id");
&entry.batch
})
.map(|k| (batch_id_array_pos[&k.batch_id], k.index))
.collect();

// At this point `indices` contains indexes within the
Expand Down