feat(spark): implement Spark map function map_from_entries
#17779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
approved these changes
Sep 27, 2025
Contributor
Jefffrey
left a comment
Jefffrey
left a comment
There was a problem hiding this comment.
Looks good, some suggestions for more tests
Jefffrey
reviewed
Sep 27, 2025
Contributor
There was a problem hiding this comment.
Perhaps add tests for SELECT map_from_entries(NULL) and also when you have a null key?
Contributor
There was a problem hiding this comment.
Yeah, there is a test from ([], null) we can also have otherwise (null, [])
Contributor
Author
There was a problem hiding this comment.
Thank you for examples!
Added some tests for input with nulls:
- nulltype instead of array (failed as expected)
- array with nulltype instead of struct (failed as expected)
- array with null key (failed as expected)
- array with null entries - this was failing instead of returning correct result
so added and rewritten some code to fix it
comphead
reviewed
Sep 27, 2025
| ---- | ||
| {outer_key1: {inner_a: 1, inner_b: 2}, outer_key2: {inner_x: 10, inner_y: 20, inner_z: 30}} | ||
|
|
||
| # Test with duplicate keys |
Contributor
There was a problem hiding this comment.
nice, last win strategy in action
comphead
approved these changes
Sep 27, 2025
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
Thanks @SparkApplicationMaster I think it is LGTM
…tial offsets, add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
part of #15914
Rationale for this change
Migrate spark functions from https://github.com/lakehq/sail/ to datafusion engine to unify codebase
What changes are included in this PR?
implement spark udf
map_from_entrieshttps://spark.apache.org/docs/latest/api/sql/index.html#map_from_entries
Are these changes tested?
sqllogictests added
Are there any user-facing changes?
map_from_entries(key_value_struct_list)now can be called in queries