minor: Make FunctionRegistry udafs and udwfs methods mandatory
#17847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
github-actions
bot
added
the
documentation
alamb
approved these changes
Oct 1, 2025
|
|
||
| ### `FunctionRegistry` exposes two additional methods | ||
|
|
||
| `FunctionRegistry` exposes two additional methods `udafs` and `udwfs` which expose set of registered user defined aggregation and window function names. To upgrade implement methods returning set of registered function names: |
martin-g
approved these changes
Oct 2, 2025
Contributor
|
Thanks @milenkovicm and @martin-g |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is follow up on #17649 and #17650 to make
FunctionRegistryudafsandudwfsmethods as unimplemented after we have back-ported initial implementation to 50.1 branchRationale for this change
as described in ##17649
What changes are included in this PR?
udafsandudwfsmethods are not implemented inFunctionRegistrytraitAre these changes tested?
yes
Are there any user-facing changes?