chore: utilize trait upcasting for AsyncScalarUDF PartialEq & Hash #17872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
commented
Oct 2, 2025
datafusion/expr/src/async_udf.rs
Outdated
Comment on lines
231
to
237
| // Inner is distinct arc -> still equal | ||
| let a = AsyncScalarUDF::new(Arc::new(TestAsyncUDFImpl1 { a: 1 })); | ||
| let b = AsyncScalarUDF::new(Arc::new(TestAsyncUDFImpl1 { a: 1 })); | ||
| assert_eq!(a, b); | ||
| let mut set = HashSet::new(); | ||
| set.insert(a); | ||
| assert!(set.contains(&b)); |
Contributor
Author
There was a problem hiding this comment.
This test would have failed before; it succeeding is new behaviour introduced by this change.
findepi
approved these changes
Oct 2, 2025
Member
findepi
left a comment
findepi
left a comment
There was a problem hiding this comment.
This is really a nice chance!
Couple editorial comments
datafusion/expr/src/async_udf.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| fn udf_equality_and_hash() { |
Member
There was a problem hiding this comment.
it's generally beneficial to test eq, hash and ord together, because their contracts are closely related
see existing test_partial_eq_hash_and_partial_ord for example
Contributor
Author
There was a problem hiding this comment.
I notice we don't have PartialOrd impl for AsyncScalarUDF; should we just copy the implementation from ScalarUDF and implement it in this PR?
findepi
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clearing a TODO item I noticed, since we're now MSRV of 1.87.0:
datafusion/Cargo.toml
Lines 78 to 79 in 3ee52f8
Utilize
dyn_eqanddyn_hashvia trait upcasting. There is a slight change in behaviour given the pointers inside the Arcs aren't being compared anymore, see comment.