chore: Extend backtrace coverage for Execution and Internal errors
#17921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
github-actions
bot
added
logical-expr
Contributor
Author
|
I'm actually thinking to create custom lint or script which should check errors implementation for PRs to automate checks |
Contributor
Author
|
Just FYI: used Claude and Roo Code to mass change to test it out, |
dqkqd
reviewed
Oct 5, 2025
dqkqd
reviewed
Oct 5, 2025
dqkqd
reviewed
Oct 5, 2025
dqkqd
reviewed
Oct 5, 2025
alamb
changed the title
Execution and Internal errors
alamb
approved these changes
Oct 6, 2025
datafusion/execution/src/task.rs
Outdated
| "There is no UDWF named \"{name}\" in the TaskContext" | ||
| )) | ||
| internal_datafusion_err!( | ||
| "There is no UDWF named \"{}\" in the TaskContext", |
Contributor
There was a problem hiding this comment.
why not keep the inline format?
Suggested change
| "There is no UDWF named \"{}\" in the TaskContext", | |
| "There is no UDWF named \"{name}\" in the TaskContext", |
?
| "Unable to retrieve field in WindowUDF via FFI".to_string(), | ||
| )), | ||
| true => exec_err!( | ||
| "Unable to retrieve field in WindowUDF via FFI - schema has no fields" |
| .map_err(|e| { | ||
| DataFusionError::Internal(format!("Failed to decode from base64: {e}")) | ||
| }) | ||
| .map_err(|e| internal_datafusion_err!("Failed to decode from base64: {}", e)) |
Contributor
There was a problem hiding this comment.
likewise in this this file, why not put the exception inline?
Contributor
Author
There was a problem hiding this comment.
this is how Claude works 🤔 Thanks for pointing this out
Contributor
There was a problem hiding this comment.
Probably trained on too much old rust code 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Replace raw
DataFusionErrorwith backtrace supported onesThe PR just replaces
DataFusionError::ExecutionandDataFusionError::Internalto use error macros insteadWhat changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?