bench: fix actually generate a lot of unique values in benchmark table #17967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also added benchmark for testing pure grouping performance for more than 1 column.
----
I run this query for the data:
```
SELECT
COUNT(*) AS total_count,
COUNT(DISTINCT u64_wide) AS unique_count,
COUNT(DISTINCT u64_wide) * 1.0 / COUNT(*) AS cardinality
FROM t;
```
Before:
```
| total_count | unique_count | cardinality |
| ----------- | ------------ | ----------- |
| 65536 | 2048 | 0.03125 |
```
After:
```
| total_count | unique_count | cardinality |
| ----------- | ------------ | ----------- |
| 65536 | 65536 | 1.0 |
```
rluvaton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
the benchmark did not test what it expected (I think), i.e.
u64_widewas the same in every batch.I run this query for the data:
Before:
After:
What changes are included in this PR?
i. u64_wide and utf8
ii. u64_wide and f32
Are these changes tested?
No need
Are there any user-facing changes?
Nope