Skip to content

fix docs and broken example from #17956 #17980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
+5 −5
Merged

fix docs and broken example from #17956 #17980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions datafusion-examples/examples/advanced_parquet_index.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ impl ParquetFileReaderFactory for CachedParquetFileReaderFactory {
// for this example we ignore the partition index and metrics
// but in a real system you would likely use them to report details on
// the performance of the reader.
let filename = partition_file
let filename = partitioned_file
.object_meta
.location
.parts()
Expand All @@ -573,8 +573,8 @@ impl ParquetFileReaderFactory for CachedParquetFileReaderFactory {

let object_store = Arc::clone(&self.object_store);
let mut inner =
ParquetObjectReader::new(object_store, partition_file.object_meta.location)
.with_file_size(partition_file.object_meta.size);
ParquetObjectReader::new(object_store, partitioned_file.object_meta.location)
.with_file_size(partitioned_file.object_meta.size);

if let Some(hint) = metadata_size_hint {
inner = inner.with_footer_size_hint(hint)
Expand Down
4 changes: 2 additions & 2 deletions datafusion/datasource/src/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,11 +249,11 @@ pub enum RangeCalculation {
/// Calculates an appropriate byte range for reading from an object based on the
/// provided metadata.
///
/// This asynchronous function examines the `FileMeta` of an object in an object store
/// This asynchronous function examines the [`PartitionedFile`] of an object in an object store
/// and determines the range of bytes to be read. The range calculation may adjust
/// the start and end points to align with meaningful data boundaries (like newlines).
///
/// Returns a `Result` wrapping a `RangeCalculation`, which is either a calculated byte range or an indication to terminate early.
/// Returns a `Result` wrapping a [`RangeCalculation`], which is either a calculated byte range or an indication to terminate early.
///
/// Returns an `Error` if any part of the range calculation fails, such as issues in reading from the object store or invalid range boundaries.
pub async fn calculate_range(
Expand Down