Skip to content

Conversation

@realno
Copy link
Contributor

@realno realno commented Feb 9, 2022

Which issue does this PR close?

This looks like a dupe with #1801, will wait for that to be merged then test and close.

Rationale for this change

Fixing the following error message on M1 Mac

   Compiling datafusion-cli v7.0.0 (/Users/realno/Dev/arrow-datafusion/datafusion-cli)
error[E0046]: not all trait items implemented, missing: `output_ordering`
   --> ballista/rust/core/src/serde/mod.rs:713:5
    |
713 |     impl ExecutionPlan for TopKExec {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `output_ordering` in implementation
    |
    = help: implement the missing item: `fn output_ordering(&self) -> std::option::Option<&[PhysicalSortExpr]> { todo!() }`

For more information about this error, try `rustc --explain E0046`.
error: could not compile `ballista-core` due to previous error
warning: build failed, waiting for other jobs to finish...
error: build failed

What changes are included in this PR?

Fixing build issue.

Are there any user-facing changes?

No

@realno realno changed the title Fix build on m1 mac Draft: Fix build on m1 mac Feb 9, 2022
@alamb
Copy link
Contributor

alamb commented Feb 9, 2022

I think this was also fixed in #1801

@realno realno closed this Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants