chore: Use an enum to express the different kinds of nullability in an array #18048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
My code was copied from https://github.com/apache/datafusion/blob/main/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/primitive.rs#L142 and there are similar matches in the other files in the module as well, so might as well use the enum in them as well. |
Member
Author
|
I've updated all files in |
tobixdev
pushed a commit
to tobixdev/datafusion
that referenced
this pull request
Nov 2, 2025
…n array (apache#18048) * chore: Use an enum to express the different kinds of nullability in an array Follow-up of apache#17726 (review) * Use the Nulls enum also in .../multi_group_by/primitive.rs * Use the Nulls enum in .../multi_group_by/bytes[_view].rs as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #17726 (review)
Which issue does this PR close?
Rationale for this change
Using
Some(true),Some(false)andNonefor the number of nulls in an array are not very clear.Using an enum with a well named variants is clearer.
What changes are included in this PR?
Introduce a local scoped enum for the needs of the function.
Are these changes tested?
The change reuses the tests from #18047
Are there any user-facing changes?
No