Skip to content

chore: remove unnecessary skip_failed_rules config in slt #18117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
+0 −8
Merged

chore: remove unnecessary skip_failed_rules config in slt #18117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions datafusion/sqllogictest/test_files/timestamps.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,11 +643,7 @@ select date '1994-01-01' - interval '1' day as date;
----
1993-12-31


# cast_string_to_time()
statement ok
set datafusion.optimizer.skip_failed_rules = false

query DDDD
select
time '08:09:10.123456789' as time_nano,
Expand All @@ -668,10 +664,6 @@ SELECT TIME '24:01:02' as time;
query error Arrow error: Parser error: Invalid timezone "ZZ": failed to parse timezone
SELECT TIMESTAMP '2023-12-05T21:58:10.45ZZ';

statement ok
set datafusion.optimizer.skip_failed_rules = true


# cast_to_timestamp_twice
query P
select to_timestamp(a) from (select to_timestamp(1) as a) A;
Expand Down