[branch-50] fix(SubqueryAlias): use maybe_project_redundant_column (#17478) #18130
+197
−198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
This was referenced Oct 17, 2025
* fix(SubqueryAlias): use maybe_project_redundant_column Fixes apache#17405 * chore: format * ci: retry * chore(SubqueryAlias): restructore duplicate detection and add tests * docs: add examples and context to the reproducer
hareshkh
force-pushed
the
hareshkh/maybe_project_redundant_column
branch
from
ed5cf8f to
c77d96f
Compare
|
Merging to pick up #18141 and try and get a clean CI run |
alamb
approved these changes
Oct 19, 2025
There was a problem hiding this comment.
Thank you @hareshkh
fyi @notfilippo and @NGA-TRAN and @LiaCastaneda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
change_redundant_columnlossy approach breaks logical optimizer and physical planner #1740550.3.0(minor) #18072Rationale for this change
See #17478
What changes are included in this PR?
See #17478
Are these changes tested?
Are there any user-facing changes?