fix: wrong simplification for >= >, <= < #18222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optimizer
adriangb
reviewed
Oct 22, 2025
| ) WHERE int_col >= 1 AND int_col <= 10; | ||
| ---- | ||
| logical_plan | ||
| 01)Filter: test_data.int_col > Int32(1) AND test_data.int_col < Int32(10) |
Contributor
There was a problem hiding this comment.
Currently this produces FilterExec: int_col@0 >= 1 AND int_col@0 <= 10
adriangb
approved these changes
Oct 22, 2025
Contributor
|
Thanks @chenkovsky |
tobixdev
pushed a commit
to tobixdev/datafusion
that referenced
this pull request
Nov 2, 2025
## Which issue does this PR close? - Closes apache#18214. ## Rationale for this change In find_most_restrictive_predicate, operation is ignored, but it should be considered when boundaries are equal. ## What changes are included in this PR? check the operator, when boundaries are equal. ## Are these changes tested? UT ## Are there any user-facing changes? No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
In find_most_restrictive_predicate, operation is ignored, but it should be considered when boundaries are equal.
What changes are included in this PR?
check the operator, when boundaries are equal.
Are these changes tested?
UT
Are there any user-facing changes?
No