fix: map benchmark failing #18469
Merged
fix: map benchmark failing #18469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which issue does this PR close? - map benchmark failing apache#18454 Rationale for this change - Map expects list, large_list or fixed_size_list but Scalar type is provided What changes are included in this PR? - Change the types to the types of keys and values Are these changes tested? - Previously failing tests pass Are there any user-facing changes? N/A
Contributor
|
LGTM, thanks! |
Jefffrey
approved these changes
Nov 4, 2025
Closed
codetyri0n
pushed a commit
to codetyri0n/datafusion
that referenced
this pull request
Nov 11, 2025
## Which issue does this PR close? - map benchmark failing apache#18454 ## Rationale for this change - Map expects list, large_list or fixed_size_list but Scalar type is provided ## What changes are included in this PR? - Change the types to the types of keys and values ## Are these changes tested? - Previously failing tests pass ## Are there any user-facing changes? N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
N/A