fix: shuffle seed #18518
Merged
fix: shuffle seed #18518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
reviewed
Nov 7, 2025
| pub fn new() -> Self { | ||
| Self { | ||
| signature: Signature::arrays(1, None, Volatility::Volatile), | ||
| signature: Signature::user_defined(Volatility::Volatile), |
Contributor
There was a problem hiding this comment.
We should avoid using user_defined and make use of TypeSignature::ArraySignature, for example:
datafusion/datafusion/expr-common/src/signature.rs
Lines 1247 to 1262 in 7591919
- Index can be used as seed since it is Int64 type
- We can't use
Signature::array_and_indexdirectly since that would coerce FixedSizeLists to List arrays, which we don't want since we have a native implementation for FixedSizeLists - Ensure there is support for both array only, and array + seed
Comment on lines
25
to
27
| SELECT shuffle([1, 2, 3, 4, 5, NULL]) != [1, 2, 3, 4, 5, NULL]; | ||
| SELECT shuffle([1, 2, 3, 4, 5, NULL], 1) != [1, 2, 3, 4, 5, NULL]; | ||
| ---- | ||
| true |
Contributor
There was a problem hiding this comment.
We can just assert the output list instead of it being an inequality with its sorted version now, e.g.
query ?
SELECT shuffle([1, 2, 3, 4, 5, NULL], 1);
----
[2, 5, NULL, 3, 4, 1]
Comment on lines
71
to
73
| if arg_types.is_empty() { | ||
| return plan_err!("shuffle expects at least 1 argument"); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if arg_types.is_empty() { | |
| return plan_err!("shuffle expects at least 1 argument"); | |
| } |
We don't need this check
Jefffrey
approved these changes
Nov 7, 2025
alamb
reviewed
Nov 8, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @chenkovsky and @Jefffrey
hsiang-c
pushed a commit
to hsiang-c/datafusion
that referenced
this pull request
Nov 9, 2025
## Which issue does this PR close? - Closes apache#18476. ## Rationale for this change shuffle test sometimes fails ## What changes are included in this PR? add seed to shuffle, make sure slt won't fail. ## Are these changes tested? UT ## Are there any user-facing changes? No
codetyri0n
pushed a commit
to codetyri0n/datafusion
that referenced
this pull request
Nov 11, 2025
## Which issue does this PR close? - Closes apache#18476. ## Rationale for this change shuffle test sometimes fails ## What changes are included in this PR? add seed to shuffle, make sure slt won't fail. ## Are these changes tested? UT ## Are there any user-facing changes? No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
shuffle.sltIntermittent CI failure forSELECT shuffle([1, 2, 3, 4, 5, NULL]) != [1, 2, 3, 4, 5, NULL];#18476.Rationale for this change
shuffle test sometimes fails
What changes are included in this PR?
add seed to shuffle, make sure slt won't fail.
Are these changes tested?
UT
Are there any user-facing changes?
No