Clarify tests for Interval::and, Interval::not, and add Interval::or tests
#18621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepijnve
changed the title
Interval::and, 'Interval::not, and add Interval::or` tests
pepijnve
changed the title
Interval::and, 'Interval::not, and add Interval::or` testsInterval::and, Interval::not, and add Interval::or tests
alamb
approved these changes
Nov 11, 2025
| (false, true, true, true, false, true), | ||
| (false, false, false, false, false, false), | ||
| (true, true, true, true, true, true), | ||
| ( |
Contributor
There was a problem hiding this comment.
😍 -- this is much easier to understand
Maybe we could also add a comment explaining what each field is -- <arg0> AND <arg1> and expected output <arg0>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None, unit test clarification
Rationale for this change
The unit tests for
Interval::and, andInterval::notare written using a hard to to interpret matrix of boolean values. It's much easier to scan this for correctness when using the constants instead.What changes are included in this PR?
Interval::orAre these changes tested?
Test only change
Are there any user-facing changes?
No