-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: allow custom caching via logical node #18688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jizezhang
wants to merge
25
commits into
apache:main
Choose a base branch
from
jizezhang:cache-udn
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
c2deee7
feat: allow custom caching via logical node
jizezhang e83038a
formatting
jizezhang d9cd725
fix import
jizezhang b17e5bb
remove unused test imports
jizezhang 8ae150f
minor: Use allow->expect to explicitly suppress Clippy lint checks (#…
2010YOUY01 13a8a3b
chore(deps): bump taiki-e/install-action from 2.62.50 to 2.62.51 (#18…
dependabot[bot] bc88780
chore(deps): bump crate-ci/typos from 1.39.1 to 1.39.2 (#18694)
dependabot[bot] ad7bea8
Remove FilterExec from CoalesceBatches optimization rule, add fetch s…
Dandandan 0af2832
minor: refactor with `assert_or_internal_err!()` in `datafusion/datas…
kumarUjjawal 244456f
chore: Enforce lint rule `clippy::needless_pass_by_value` to datafusi…
AryanBagade 13adf2a
feat: Handle edge case with `corr` with single row and `NaN` (#18677)
comphead ac86c20
[main] Update changelog for 51.0.0 RC2 (#18710)
alamb 8ce7aca
Refactor Spark crc32/sha1 signatures (#18662)
Jefffrey aaabd1f
feat: support spark csc (#18642)
psvri d61021c
CI: try free up space in `Rust / cargo test (amd64)` action (#18709)
Jefffrey a1c04c9
chore: enforce clippy lint needless_pass_by_value to datafusion-proto…
foskey51 1921919
chore: enforce clippy lint needless_pass_by_value to datafusion-spark…
foskey51 55b8055
pass session state to cache producer
jizezhang 376453b
Merge branch 'main' into cache-udn
jizezhang f95bc67
fix imports in doc
jizezhang da949d5
Merge branch 'main' into cache-udn
jizezhang cb0b43c
Merge branch 'main' into cache-udn
jizezhang 213c6f6
refactor
jizezhang 1c67bec
update doc and comment
jizezhang 5d1c999
fix test name
jizezhang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to test the physical plan too
Does it need a custom ExtensionPlanner too for that ?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we need to cover physical plan for this case, as it would be up to user to provide it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be used as an example how to do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps we can do it as a follow up in examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, once this PR is approved and merged, I can work on writing up an example.