Skip to content

chore: enforce clippy lint needless_pass_by_value to datafusion-datasource-parquet #18695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 17, 2025
Merged

chore: enforce clippy lint needless_pass_by_value to datafusion-datasource-parquet #18695

merged 3 commits into from
Nov 17, 2025

Conversation

@foskey51
Copy link
Contributor

@foskey51 foskey51 commented Nov 14, 2025

Which issue does this PR close?

What changes are included in this PR?

enforce clippy lint needless_pass_by_value to datafusion-datasource-parquet

Are these changes tested?

yes

Are there any user-facing changes?

no

@github-actions github-actions bot added core Core DataFusion crate proto Related to proto crate datasource Changes to the datasource crate labels Nov 14, 2025
@foskey51
Copy link
Contributor Author

foskey51 commented Nov 14, 2025

we'll have to re-trigger the ci check again (issue addressed #18692)

Unhandled exception. System.IO.IOException: No space left on device : '/home/runner/actions-runner/cached/_diag/Worker_20251114-085328-utc.log'
at System.IO.RandomAccess.WriteAtOffset(SafeFileHandle handle, ReadOnlySpan`1 buffer, Int64 fileOffset)
at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
at System.Diagnostics.TextWriterTraceListener.Flush()

@Jefffrey Jefffrey mentioned this pull request Nov 15, 2025
Open
38 tasks
Jefffrey
Jefffrey reviewed Nov 15, 2025
View reviewed changes
datafusion/datasource-parquet/src/file_format.rs Outdated
pub fn statistics_from_parquet_meta_calc(
metadata: &ParquetMetaData,
table_schema: SchemaRef,
table_schema: &SchemaRef,
Copy link
Contributor

@Jefffrey Jefffrey Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a public API break?

Copy link
Contributor Author

@foskey51 foskey51 Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find any references to this function (I guess bcz it was deprecated after 50.0.0 and this statistics_from_parquet_metadata took over it). So I ended up marking it with #[expect(clippy::needless_pass_by_value)]

@github-actions github-actions bot removed core Core DataFusion crate proto Related to proto crate labels Nov 15, 2025
@Jefffrey Jefffrey added this pull request to the merge queue Nov 17, 2025
Merged via the queue into apache:main with commit 5791822 Nov 17, 2025
28 checks passed
@foskey51 foskey51 deleted the chore/needless-pass-by-value-datafusion-datasource-parquet branch November 17, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jefffrey Jefffrey Jefffrey approved these changes

Assignees

No one assigned

Labels

datasource Changes to the datasource crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enforce lint rule clippy::needless_pass_by_value to datafusion-datasource-parquet

2 participants

@foskey51 @Jefffrey