fix: Disable table name normalisation as default behaviour #18708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion.sql_parser.enable_ident_normalization=falsebehaviour #18675.Rationale for this change
There are cases for which case sensitive column names and table references are needed, so having forced
to_ascii_lowercasefor names breaks support for them.datafusion.sql_parser.enable_ident_normalization=falsewill help with column names but table names and few other things will be converted to lowercase, or not (as described in the bug)This is potentially VERY BREAKING change, it disables forced
to_ascii_lowercasefor table reference and columns, as behaviour was hardcoded.What changes are included in this PR?
Are these changes tested?
yes
Are there any user-facing changes?
yes, some users can be affected if they have
enable_ident_normalizationdisabled or if they rely on datafusion to automatically doident_normalization