fix: Nested arrays should not get a field in lookup #18745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
approved these changes
Nov 16, 2025
| .build(std::io::Cursor::new(bytes)) | ||
| .unwrap(); | ||
|
|
||
| // This should fail because schema_lookup will have "items.element.id" and "items.element.name" |
Member
There was a problem hiding this comment.
This should fail ... but it passes!
Maybe reword it to "This was failing before #18745 because ..." ?
Contributor
Author
There was a problem hiding this comment.
You're right, thank you^
Weijun-H
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Fixes a critical bug, as well as behaves more like avro expects in regards to arrays.
What changes are included in this PR?
Removed the sub label from arrays in general
Are these changes tested?
Yes
Are there any user-facing changes?
Not really