Skip to content

Conversation

@rluvaton
Copy link
Member

Which issue does this PR close?

Rationale for this change

Just adding tests to see what fails

What changes are included in this PR?

added for all fuzz tests in join to have different amount of columns in each side

Are these changes tested?

N/A

Are there any user-facing changes?

Nope

@github-actions github-actions bot added the core Core DataFusion crate label Nov 17, 2025
@rluvaton
Copy link
Member Author

These new tests found 9 failures:

  • test_left_join_1k_binary_filtered
  • test_left_join_1k_filtered
  • test_left_mark_join_1k_binary_filtered
  • test_left_mark_join_1k_filtered
  • test_right_anti_join_1k_binary_filtered
  • test_right_anti_join_1k_filtered
  • test_right_join_1k_binary_filtered
  • test_right_join_1k_filtered
  • test_right_mark_join_1k_binary_filtered
  • test_right_mark_join_1k_filtered
  • test_right_semi_join_1k_filtered

github-merge-queue bot pushed a commit that referenced this pull request Nov 18, 2025
## Which issue does this PR close?

- Closes #18804.

## Rationale for this change

## What changes are included in this PR?

Take correct columns

## Are these changes tested?

Yes, 

- added rust tests to hit invalid code paths
- sqltests
- fuzz tests enhancement to fuzzify columns count

Fuzz tests are taken from @rluvaton 's #18788 , excluding those this PR
doesn't fix:

```
    fuzz_cases::join_fuzz::test_right_anti_join_1k_binary_filtered
    fuzz_cases::join_fuzz::test_right_anti_join_1k_filtered
    fuzz_cases::join_fuzz::test_right_semi_join_1k_filtered
```

## Are there any user-facing changes?
@rluvaton
Copy link
Member Author

Closed in favor of the PR that fix it

@rluvaton rluvaton closed this Nov 20, 2025
@rluvaton rluvaton deleted the add-tests-for-different-number-of-column-in-join branch November 20, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant