feat: Improve read types support [Avro] #18809
Open
+388
−56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #18810 .
Rationale for this change
Performance of the Avro reader is currently dismal :(
While going over it, I saw a couple opportunities for improvements, but then I noticed the lack of support for binary types,
this is something I'd like to tackle early on.
What changes are included in this PR?
Are these changes tested?
The new nested support is tested by modifying the existing
test_complex_listtest, the move to cow is tested via all the current tests that test strings and binaries.Added a new test to test fixed type, both in normal and list circumstances.
Are there any user-facing changes?
No, just extended support