Remove unnecessary bit counting code from spark bit_count
#18841
+6
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Spark's
bit_countfunction always operators on 64-bit values, while the originalbit_countimplementation indatafusion_sparkoperated on the native size of the input value.In order to fix this a custom bit counting implementation was ported over from the Java Spark implementation. This isn't really necessary though. Widening signed integers to
i64and then usingi64::count_oneswill get you the exact same result and is less obscure.What changes are included in this PR?
Remove custom
bitcountlogic and usei64::count_onesinstead.Are these changes tested?
Covered by existing tests that were added for #18225
Are there any user-facing changes?
No