chore: Enforce clippy::needless_pass_by_value globally across the workspace
#18904
+55
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
clippy::needless_pass_by_valuein all datafusion crates #18503Rationale for this change
We have already enforce the lint rule for all workspace crates, now we can enable it globally.
In this PR:
cargo.tomldatafusion-examples, tests) have not been fixed before, and after we have enable the linter rule at workspace level, these violations showed up. This PR suppresses all of them, since those violations are acceptable.For example when we enforce it in
datafusion-sql, in itslib.rs, we haveThis enforces the rule at the crate level but ignores all violations in tests. We cannot disable lint checks for tests from the global (top-level Cargo.toml) configuration, so we have to keep these per-crate settings until Cargo or Clippy adds support for this in the future. I'll leave a note in the tracking issue.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?