Skip to content

Conversation

@kumarUjjawal
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

Centralize <slt:ignore> handling so the validator and error output use the same logic, eliminating false-positive diffs.

What changes are included in this PR?

  • df_value_validator now records mismatch context (expected/actual snapshots + reason) via a shared helper.
  • The sqllogictest runner consumes that context to print [Reason]/[Expected]/[Actual] instead of the old diff.

Are these changes tested?

  • Added targeted tests covering ignore markers and trailing-data handling.

Are there any user-facing changes?

Note for the reviewers

  • I have understanding of the general issue and the what I wanted to do, but I am not fully confident in my implementation, I also used LLM for the help while structuring parts of the code when my build was failing repeatedly.

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve error message in sqllogictest with <slt:ignore> marker

1 participant