Implement CatalogProviderList in FFI (#18657) #18912
Open
+428
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Which issue does this PR close? None ## Rationale for this change This is continuation of work in the FFI crate to expose useful traits. We currently have FFI catalog, schema, and table providers. The next layer up in the heirarchy is the catalog provider list. ## What changes are included in this PR? - Implement FFI_CatalogProviderList - Add unit tests and integration tests - Minor rearrangement of integration test for catalog ## Are these changes tested? Yes, included in PR. ## Are there any user-facing changes? This is only new addition to the FFI crate. No existing code is modified except making one data member pub(crate)
Member
Author
|
Github is having some issues, I'll try rerunning CI at a later time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is related to #18843
Rationale for this change
This is a pure addition that users would like to use and it barely missed the cutoff for 51.0.0
What changes are included in this PR?
Adds in
FFI_CatalogProviderListAre these changes tested?
Yes, and already in
mainAre there any user-facing changes?
No, pure addition