fix: partition pruning stats pruning when multiple values are present #18923
+74
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e present Signed-off-by: Nimalan <nimalan.m@protonmail.com>
dqkqd
approved these changes
Nov 25, 2025
|
|
||
| let values = HashSet::from([ScalarValue::from(1i32), ScalarValue::from(3i32)]); | ||
| let contained_a = partition_stats.contained(&column_a, &values).unwrap(); | ||
| let expected_contained_a = BooleanArray::from(vec![true, true]); |
Contributor
There was a problem hiding this comment.
The stats:
| a | b |
|---|---|
| 1 | 2 |
| 3 | 4 |
Running contained on a with values = [1, 3] returns [true, true].
I wonder if we need some cases that return false, or None as well.
Author
There was a problem hiding this comment.
The earlier case covers false. I've added a test cases for the null scenario, changed the or to a or_kleene so it works for null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18922