Skip to content

Fix tpch benchmark harness #19033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2025
Merged

Fix tpch benchmark harness #19033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions benchmarks/src/tpch/run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,8 @@ pub struct RunOpt {
prefer_hash_join: BoolDefaultTrue,

/// If true then Piecewise Merge Join can be used, if false then it will opt for Nested Loop Join
/// True by default.
#[structopt(
short = "j",
Copy link
Contributor Author

@alamb alamb Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-j is repeated

Prior to this change, the binary fails like this:

thread 'main' (1416474) panicked at /Users/andrewlamb/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/clap-2.34.0/src/app/parser.rs:190:13:
Argument short must be unique

	-j is already in use
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Copy link
Contributor Author

@alamb alamb Dec 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is to remove the -j short form

long = "enable_piecewise_merge_join",
default_value = "false"
)]
/// False by default.
#[structopt(long = "enable_piecewise_merge_join", default_value = "false")]
enable_piecewise_merge_join: BoolDefaultTrue,

/// Mark the first column of each table as sorted in ascending order.
Expand Down