Skip to content

refactor: make Ctes a struct to also store data types provided by prepare stmt #4520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2022
Merged

refactor: make Ctes a struct to also store data types provided by prepare stmt #4520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c08c59
refactor: make Ctes a struct to also store data types provided by pre…
NGA-TRAN Dec 5, 2022
9964626
chore: rename ctes to planner_context
NGA-TRAN Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions datafusion/core/tests/sqllogictests/src/insert/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,8 @@ use datafusion::datasource::MemTable;
use datafusion::prelude::SessionContext;
use datafusion_common::{DFSchema, DataFusionError};
use datafusion_expr::Expr as DFExpr;
use datafusion_sql::planner::SqlToRel;
use datafusion_sql::planner::{PlannerContext, SqlToRel};
use sqlparser::ast::{Expr, SetExpr, Statement as SQLStatement};
use std::collections::HashMap;
use std::sync::Arc;

pub async fn insert(ctx: &SessionContext, insert_stmt: &SQLStatement) -> Result<String> {
Expand Down Expand Up @@ -66,7 +65,11 @@ pub async fn insert(ctx: &SessionContext, insert_stmt: &SQLStatement) -> Result<
let logical_exprs = row
.into_iter()
.map(|expr| {
sql_to_rel.sql_to_rex(expr, &DFSchema::empty(), &mut HashMap::new())
sql_to_rel.sql_to_rex(
expr,
&DFSchema::empty(),
&mut PlannerContext::new(),
)
})
.collect::<std::result::Result<Vec<DFExpr>, DataFusionError>>()?;
// Directly use `select` to get `RecordBatch`
Expand Down
Loading