Skip to content

Fix Stack overflow in sql planning in debug builds #4779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 1, 2023
Merged

Fix Stack overflow in sql planning in debug builds #4779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4d82875
fix: stackoverflow in planning tpcds queries
alamb Dec 31, 2022
998eee4
uncomment some other tests
alamb Dec 31, 2022
cefbbfc
fix: fmt
alamb Dec 31, 2022
bbdcfe5
Apply suggestions from code review
alamb Dec 31, 2022
e45065e
Update datafusion/core/tests/tpcds_planning.rs
alamb Dec 31, 2022
8276b64
fix: clippy
alamb Jan 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions datafusion/core/tests/tpcds_planning.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ async fn tpcds_logical_q3() -> Result<()> {
create_logical_plan(3).await
}

#[ignore] // thread 'q4' has overflowed its stack
#[tokio::test]
async fn tpcds_logical_q4() -> Result<()> {
create_logical_plan(4).await
Expand Down Expand Up @@ -179,7 +178,6 @@ async fn tpcds_logical_q30() -> Result<()> {
create_logical_plan(30).await
}

#[ignore] // thread 'q31' has overflowed its stack
#[tokio::test]
async fn tpcds_logical_q31() -> Result<()> {
create_logical_plan(31).await
Expand Down Expand Up @@ -345,7 +343,7 @@ async fn tpcds_logical_q63() -> Result<()> {
create_logical_plan(63).await
}

#[ignore] // thread 'q64' has overflowed its stack
#[ignore] // thread 'q64' has overflowed its stack]
#[tokio::test]
async fn tpcds_logical_q64() -> Result<()> {
create_logical_plan(64).await
Expand Down Expand Up @@ -541,7 +539,6 @@ async fn tpcds_physical_q3() -> Result<()> {
create_physical_plan(3).await
}

#[ignore] // thread 'q4' has overflowed its stack
#[tokio::test]
async fn tpcds_physical_q4() -> Result<()> {
create_physical_plan(4).await
Expand Down Expand Up @@ -683,7 +680,6 @@ async fn tpcds_physical_q30() -> Result<()> {
create_physical_plan(30).await
}

#[ignore] // thread 'q31' has overflowed its stack
#[tokio::test]
async fn tpcds_physical_q31() -> Result<()> {
create_physical_plan(31).await
Expand Down
Loading