Minor: Move TableProviderFactories up out of RuntimeEnv and into SessionState
#5477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Mar 4, 2023
| self.session_id.clone() | ||
| } | ||
|
|
||
| /// Return the [`TableFactoryProvider`] that is registered for the |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| /// Return the [`TableFactoryProvider`] that is registered for the | |
| /// Return the [`TableProviderFactory`] that is registered for the |
| }; | ||
| use std::collections::HashMap; | ||
|
|
||
| use crate::datasource::datasource::TableProviderFactory; |
Contributor
Author
There was a problem hiding this comment.
The whole point of the PR is to remove the datasource dependency from the runtime_env module (as I am trying to move the runtime_env module into a new crate, datafusion-execution, that does not depend on datasource)
I plan to move object_store registry in a separate PR to keep the reviews smaller
| pub fn new() -> Self { | ||
| let mut table_factories: HashMap<String, Arc<dyn TableProviderFactory>> = | ||
| HashMap::new(); | ||
| table_factories.insert("PARQUET".into(), Arc::new(ListingTableFactory::new())); |
Contributor
Author
There was a problem hiding this comment.
this construction now happens as part of creating SessionState
| let env = RuntimeEnv::new(cfg).unwrap(); | ||
| let ses = SessionConfig::new(); | ||
| let ctx = SessionContext::with_config_rt(ses, Arc::new(env)); | ||
| let mut state = SessionState::with_config_rt(ses, Arc::new(env)); |
Contributor
Author
There was a problem hiding this comment.
Here is the new pattern of how to add a table provider factory
alamb
changed the title
RuntimeEnv and into SessionState
Contributor
Author
|
Thank you for the review @avantgardnerio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1754
Rationale for this change
I am trying to extract the physical_plan code into its own crate; and to do so I need to remove the circular dependencies between core --> datasource --> execution --> datasource
Table factories are used for planning, not for execution, but RuntimeEnv is used for execution (and I am trying to move it into the
datafusion_executioncrate)See more details in #1754 (comment)
What changes are included in this PR?
Are these changes tested?
Covered by existing tests (and the test changes illustrate what happened to the API). I believe this will affect Ballista (@avantgardnerio ) and delta-rs (cc @roeap )
Are there any user-facing changes?
Users who are specifying custom TableFactoryProviders have a slightly different API to register them.