Support uint64 literals #6146
Merged
Support uint64 literals #6146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be possible to compare numeric types to uint64 literals. Currently for anything above the int64 max, it will become a float or a decimal128 depending on config. The float conversion is lossy, and the decimal type is currently not comparable with uint64, so both of these are problematic.
Contributor
|
LGTM |
Contributor
|
THanks @jackkleeman and @yukkit -- I have kicked off the CI |
comphead
reviewed
Apr 29, 2023
| )) | ||
| } else if let Ok(n) = n.parse::<i64>() { | ||
| Ok(lit(n)) | ||
| } else if let Ok(n) = n.parse::<u64>() { |
Contributor
There was a problem hiding this comment.
@jackkleeman please run cargo fmt --all and resubmit the PR
Contributor
|
I took the liberty of fixing the |
Contributor
|
Thanks again @jackkleeman |
Contributor
Author
|
thanks folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to compare numeric types to uint64 literals. Currently for anything above the int64 max, it will become a float or a decimal128 depending on config. The float conversion is lossy, and the decimal type is currently not comparable with uint64, so both of these are problematic.
Which issue does this PR close?
Closes #6145.
Are these changes tested?
Yes
Are there any user-facing changes?
Potentially this will affect how some queries are interpreted, where int literals greater than int64-max are provided.