Column support for array concat #6879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
jayzhan211
commented
Jul 11, 2023
jayzhan211
commented
Jul 11, 2023
| # [[5, 6], [7, 8], [5, 6], [7, 8]] [7.7, 8.8, 9.9, 7.7, 8.8, 9.9] [d, , l, o, r, d, , l, o, r] | ||
| # [[7, ], [9, 10], [7, ], [9, 10]] [10.1, , 12.2, 10.1, , 12.2] [s, i, t, s, i, t] | ||
| # NULL [13.3, 14.4, 15.5, 13.3, 14.4, 15.5] [a, m, e, t, a, m, e, t] | ||
| # [[11, 12], [13, 14], [11, 12], [13, 14]] NULL [,, ,] |
Contributor
Author
There was a problem hiding this comment.
Not sure do we need an additional "" for commas.
Contributor
Author
|
Not all kinds of tests are passed but I think they can be solved in another PR. I think we can review this PR first. |
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Contributor
Author
izveigor
reviewed
Jul 12, 2023
|
|
||
| let builder = mutable.into_builder(); | ||
|
|
||
| let list = builder |
Contributor
There was a problem hiding this comment.
Maybe it's better to consider the method try_new? (https://docs.rs/arrow/latest/arrow/array/struct.GenericListArray.html#method.try_new) 🤔
Contributor
Author
There was a problem hiding this comment.
I prefer to construct with ListArray::new instead of MutableArrayData too, but I fail on this.
izveigor
approved these changes
Jul 12, 2023
Contributor
izveigor
left a comment
izveigor
left a comment
There was a problem hiding this comment.
Thank you, @jayzhan211! LGTM!
alamb
approved these changes
Jul 14, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @izveigor and @jayzhan211
This was referenced Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Ref #6804
Rationale for this change
Array concat with columns! Behavior is similar to Postgres.
Concat Operator
a || bis not included in this PR!What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?