[refactor](fe) Upgrade remote storage FileSystem to SPI (Phase 1)#61841
Draft
morningman wants to merge 1 commit intoapache:masterfrom
Draft
[refactor](fe) Upgrade remote storage FileSystem to SPI (Phase 1)#61841morningman wants to merge 1 commit intoapache:masterfrom
morningman wants to merge 1 commit intoapache:masterfrom
Conversation
### What problem does this PR solve? Problem Summary: Phase 1 of the Doris FE remote storage access layer refactoring. This consolidates the `fs` modules into a modern, unified, SPI-based architecture (inspired by Trino FileSystem). Key changes: 1. Introduced `Location` as a strongly-typed URI value object. 2. Introduced `FileEntry` representing zero-Hadoop file metadata. 3. Introduced `FileIterator` for lazy iteration to prevent OOM on large directories. 4. Cleaned up `FileSystem` interface (IOException-based, Location-typed) and retained the old `LegacyFileSystem` (Status-based) for backward compatibility during migration. 5. Added `LegacyFileSystemAdapter` to bridge old and new interfaces. 6. Upgraded `DorisInputFile` and `DorisOutputFile` with `location()`. 7. Created `MemoryFileSystem` for comprehensive unit testing without real storage. 8. Marked `RemoteFile` and `ParsedPath` as @deprecated with bidirectional converters. 9. Migrated Iceberg's `DelegateFileIO` to natively use the new `FileSystem` and `Location` API. ### Release note None ### Check List (For Author) - Test: - Unit Test (Added comprehensive tests for Location, FileEntry, and MemoryFileSystem. Passed all 39 new tests) - Behavior changed: No - Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Phase 1 of the Doris FE remote storage access layer refactoring. This consolidates the
fsmodules into a modern, unified, SPI-based architecture (inspired by Trino FileSystem).Key changes:
Locationas a strongly-typed URI value object.FileEntryrepresenting zero-Hadoop file metadata.FileIteratorfor lazy iteration to prevent OOM on large directories.FileSysteminterface (IOException-based, Location-typed) and retained the oldLegacyFileSystem(Status-based) for backward compatibility during migration.LegacyFileSystemAdapterto bridge old and new interfaces.DorisInputFileandDorisOutputFilewithlocation().MemoryFileSystemfor comprehensive unit testing without real storage.RemoteFileandParsedPathas @deprecated with bidirectional converters.DelegateFileIOto natively use the newFileSystemandLocationAPI.Release note
None
Check List (For Author)