Skip to content

[fix](nereids) Delete invalid signature of nvl function#16169

Merged
morrySnow merged 1 commit intoapache:masterfrom
Kikyou1997:func
Feb 3, 2023
Merged

[fix](nereids) Delete invalid signature of nvl function#16169
morrySnow merged 1 commit intoapache:masterfrom
Kikyou1997:func

Conversation

@Kikyou1997
Copy link
Copy Markdown
Contributor

  1. delete invalid signature of nvl function
  2. fix some test cases that failed because of malformed function name

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

jackwener
jackwener previously approved these changes Jan 28, 2023
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 28, 2023
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Jan 28, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.26 seconds
load time: 506 seconds
storage size: 17122695729 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230130114727_clickbench_pr_87094.html

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 29, 2023
@Kikyou1997 Kikyou1997 force-pushed the func branch 3 times, most recently from f34be2c to 932f5fe Compare February 2, 2023 10:17
2. fix some test cases that failed because of malformed function name
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 3, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2023

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit a5d9aca into apache:master Feb 3, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Feb 6, 2023
…ses (apache#16169)

1. delete invalid signature of nvl function 
2. fix some test cases that failed because of malformed function name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/nereids kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants