-
Notifications
You must be signed in to change notification settings - Fork 99
deliverers module is deprecated and removed gracefully from the system #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| # create new invokers | ||
| for url in urls: | ||
| k = str(url) | ||
| if k in old_invokers.items(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect as items() return a list of tuples.
| return self._message | ||
|
|
||
| # raise error | ||
| if self._status is DelivererStatus.FINISHED: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant, as it never entered this block if the previous condition is true; therefore, this block statement is impossible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, but the entire delivers module has been deprecated and is no longer referenced by any other module. Could you please remove the entire module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay i'll do that
… furthermore, the documentation does not mention this module
cnzakii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
#42 Updated Safely Removed |
What is the purpose of the change
Brief changelog
src/dubbo/deliverers.py:src/dubbo/cluster/directories.py:.items()to direct key lookupVerifying this change
Checklist