-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix method annotation callback do not work problem #7754
Merged
AlbumenJ
merged 4 commits into
apache:master
from
codeimport:fix_method_annotation_callback
May 15, 2021
Merged
Fix method annotation callback do not work problem #7754
AlbumenJ
merged 4 commits into
apache:master
from
codeimport:fix_method_annotation_callback
May 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7754 +/- ##
==========================================
Coverage 59.28% 59.28%
- Complexity 529 530 +1
==========================================
Files 1077 1080 +3
Lines 43565 43674 +109
Branches 6368 6376 +8
==========================================
+ Hits 25826 25891 +65
- Misses 14879 14926 +47
+ Partials 2860 2857 -3 Continue to review full report at Codecov.
|
AlbumenJ
approved these changes
May 15, 2021
AlbumenJ
added a commit
to AlbumenJ/dubbo
that referenced
this pull request
May 28, 2021
kylixs
pushed a commit
to kylixs/dubbo
that referenced
this pull request
Jun 21, 2021
AlbumenJ
pushed a commit
that referenced
this pull request
Jun 24, 2021
* Pick method callback test from #7754 * Set default value of MethodConfig fields * Fix method callback test, change to remote call * Fix tests * Tests transaction of callback method Co-authored-by: chen gang <516673669@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix #6833 when use method annotation like below,callback method dose not work
Brief changelog
Verifying this change
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.