[Feature][Integrations][Java] Support explicit tool call handling in OllamaChatModel #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi, @twosom, thanks for your contribution. LGTM. Additionally, I discover there are outputs like "Asking model: xxx" when run the example, I found that this maybe a log left by mistake in ollama4j, and it has been fixed recently. |
Signed-off-by: hope <hope@chosunbiz.com>
twosom
force-pushed
the
ollama-tool-call-handling
branch
from
928345f to
f0753e6
Compare
Contributor
Author
Thank you for your review. Version 1.1.2 was released today, and I've applied it. |
xintongsong
reviewed
Oct 21, 2025
plan/src/main/java/org/apache/flink/agents/plan/actions/ChatModelAction.java
Outdated
Show resolved
Hide resolved
xintongsong
approved these changes
Oct 22, 2025
Contributor
xintongsong
left a comment
xintongsong
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments, @twosom. LGTM
2 tasks
This was referenced Oct 29, 2025
Sxnan
added
priority/major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue: #162 #278
Purpose of change
This PR enables explicit tool call handling in OllamaChatModel to align with the flink-agents framework's design principles for observability and tool execution lifecycle management.
Tests
API
Documentation