Skip to content

[hotfix] toolCallContext not updated in ChatModelAction, causing data loss #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

[hotfix] toolCallContext not updated in ChatModelAction, causing data loss #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions plan/src/main/java/org/apache/flink/agents/plan/actions/ChatModelAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ public static void chat(
new ArrayList<>((List<ChatMessage>) toolCallContext.get(initialRequestId));

messageContext.add(response);
toolCallContext.put(initialRequestId, messageContext);
stm.set(TOOL_CALL_CONTEXT, toolCallContext);

ToolRequestEvent toolRequestEvent =
Expand Down Expand Up @@ -182,6 +183,7 @@ public static void processChatRequestOrToolResponse(Event event, RunnerContext c
extraArgs));
}
}
toolCallContext.put(initialRequestId, messages);
// overwrite tool call context
stm.set(TOOL_CALL_CONTEXT, toolCallContext);

Expand Down