Skip to content

Conversation

@wenjin272
Copy link
Collaborator

@wenjin272 wenjin272 commented Nov 19, 2025

Linked issue: #323

Purpose of change

Update the ollama4j version to resolve the tool call bug in ollama4j.

Tests

manually run e2e test

API

No

Documentation

  • doc-not-needed

@github-actions github-actions bot added priority/major Default priority of the PR or issue. fixVersion/0.2.0 The feature or bug should be implemented/fixed in the 0.2.0 version. doc-not-needed Your PR changes do not impact docs labels Nov 19, 2025
@wenjin272 wenjin272 added bug [Issue Type] Something isn't working as expected. affectVersion/0.1.0 The bug affects the 0.1.0 version. The features are not needed. labels Nov 19, 2025
@wenjin272
Copy link
Collaborator Author

The impact of this bug is that if users are using the latest version of Ollama, the ollama4j library will fail to parse the tool call returned by the LLM, but it works with previous version ollama.

We have refactored ollama chat model after 0.1.0 released, so if we want fix this issue in 0.1.1, we should create an individual pr, rather than pick this pr directly.

@Sxnan
Copy link
Contributor

Sxnan commented Nov 20, 2025

@wenjin272 Can you also create a PR against 0.1.0 to ensure it is not forgotten?

@wenjin272
Copy link
Collaborator Author

@wenjin272 Can you also create a PR against 0.1.0 to ensure it is not forgotten?

I create pr #333 to resolve this bug in release-0.1, please take a look at your convenience.

Copy link
Contributor

@Sxnan Sxnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sxnan Sxnan merged commit 4c6ceb8 into apache:main Nov 21, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

affectVersion/0.1.0 The bug affects the 0.1.0 version. The features are not needed. bug [Issue Type] Something isn't working as expected. doc-not-needed Your PR changes do not impact docs fixVersion/0.2.0 The feature or bug should be implemented/fixed in the 0.2.0 version. priority/major Default priority of the PR or issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants