[FLINK-26137] Create webhook REST api test #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gyfora @wangyang0918 @tweise , could you please help to review this pull request? |
|
Thanks a lot @SteNicholas , I will review this later today :) |
gyfora
reviewed
Mar 8, 2022
...bhook/src/test/java/org/apache/flink/kubernetes/operator/admission/AdmissionHandlerTest.java
Outdated
Show resolved
Hide resolved
|
@gyfora, thanks for detailed review. I have addressed the above comments. Please help to take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit tests to validate the webhook rest endpoint and make sure it returns the expected responses, status codes etc.
The brief change log
AdmissionHandlerTestto adds the test casestestHandleIllegalRequest,testHandleValidateRequestWithoutContentandtestHandleValidateRequestWithAdmissionReviewfor the validation of the webhook rest endpoint.