Skip to content

Conversation

@JingsongLi
Copy link
Contributor

@JingsongLi JingsongLi commented May 5, 2022

If we support append only data, the records have no primary key, the file should be data file instead of sst file.

This PR do:

  • Rename sst file to data file for classes and variables
  • Rename sst-{uuid}-{count} file name to data-{uuid}-{count} file name

Copy link
Member

@openinx openinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, thanks @JingsongLi !

@JingsongLi JingsongLi merged commit c6dcbb0 into apache:master May 6, 2022
@JingsongLi JingsongLi deleted the dataFile branch January 3, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants