[FLINK-27752] Change 'path' to 'root-path' in table store #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
commented
May 25, 2022
| import static org.apache.flink.table.store.log.LogStoreTableFactory.discoverLogStoreFactory; | ||
|
|
||
| /** Abstract table store factory to create table source and table sink. */ | ||
| public abstract class AbstractTableStoreFactory |
Contributor
Author
There was a problem hiding this comment.
Extract from TableStoreFactory.
| import static org.apache.flink.table.store.log.LogOptions.LOG_PREFIX; | ||
|
|
||
| /** Default implementation of {@link ManagedTableFactory}. */ | ||
| public class TableStoreManagedFactory extends AbstractTableStoreFactory |
Contributor
Author
There was a problem hiding this comment.
Rename from TableStoreFactory.
| } | ||
| }); | ||
|
|
||
| String rootPath = enrichedOptions.remove(ROOT_PATH.key()); |
Contributor
Author
There was a problem hiding this comment.
Enrich path and topic.
LadyForest
reviewed
May 25, 2022
| Map<String, String> options = new HashMap<>(context.getCatalogTable().getOptions()); | ||
| Preconditions.checkArgument( | ||
| !options.containsKey(TOPIC.key()), | ||
| "Managed table can not contains custom topic. " |
LadyForest
reviewed
May 25, 2022
| return map; | ||
| } | ||
|
|
||
| @Test |
Contributor
There was a problem hiding this comment.
Nit: put tests together
LadyForest
reviewed
May 25, 2022
Contributor
LadyForest
left a comment
LadyForest
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Looks good in general, and I only left some minor comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path is easy to bother the user, he/she will misinterpret it as path of table.
Let's change it to root-path, and it will be clearer.
pathtoroot-path.AbstractTableStoreFactory.pathas table path. Table Path will be generated inenrichOptions.LogStoreTableFactory.enrichOptions.It is equivalent to solidifying the
pathandtopicwhenenrichOptions, so that subsequent queries and writes can use them directly.This allows us to have a richer strategy for
path/topicgeneration, rather than being tied to generating paths based ontableIdentifier.