Skip to content

[hotfix] ALTER TABLE COMPACT should also use restored max level #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JingsongLi merged 2 commits into from
Jun 13, 2022
Merged

[hotfix] ALTER TABLE COMPACT should also use restored max level #154

JingsongLi merged 2 commits into from
Jun 13, 2022

Conversation

@LadyForest
Copy link
Contributor

@LadyForest LadyForest commented Jun 13, 2022 •
edited
Loading

Otherwise rewrite may get an IllegalArgumentException when upgrading the level.

Call chain

CompactManager#rewrite 
    => CompactManager#upgrade
        => DataFileMeta#upgrade

@LadyForest LadyForest marked this pull request as ready for review June 13, 2022 06:10
JingsongLi
JingsongLi reviewed Jun 13, 2022
View reviewed changes
...store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreWriteImpl.java Outdated
List<DataFileMeta> restoredFiles) {
return new CompactWriter(
CompactUnit.fromFiles(options.numLevels - 1, restoredFiles),
CompactUnit.fromFiles(getRestoreMaxLevel(restoredFiles) - 1, restoredFiles),
Copy link
Contributor

@JingsongLi JingsongLi Jun 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use Levels to produce CompactUnit by CompactUnit.fromLevelRuns.
In this way, we don't need to change Levels.
And we should add a test case here.

@LadyForest LadyForest requested a review from JingsongLi June 13, 2022 08:02
JingsongLi
JingsongLi approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the update.

@JingsongLi JingsongLi merged commit 9e62517 into apache:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JingsongLi JingsongLi JingsongLi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LadyForest @JingsongLi