Skip to content

Conversation

@JingsongLi
Copy link
Contributor

@JingsongLi JingsongLi commented Jun 27, 2022

See FLINK-28244

class DataFileMeta {
   String fileName;
   .....
   // store the name of extra files, extra files including changelog_file,
  // primary_key_index_file,secondary_index_file, and etc...
   List<String> extraFiles;
}

Extra files can help us for many uses, including index files, changelog files and etc...

}

/** Cache for storing {@link DataFilePathFactory}s. */
public static class DataFilePathFactoryCache {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this cache now, we can just use pathFactory.bucketPath.
Although it will convert the partition to string once at a time. The cost is not large.

@JingsongLi JingsongLi merged commit 0643906 into apache:master Jun 28, 2022
@JingsongLi JingsongLi deleted the extra branch January 3, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants