[FLINK-29291] Change DataFileWriter into a factory to create writers #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Sep 26, 2022
| // adding one record then remove one record, but after merging this record will not | ||
| // appear in lsm file. This is OK because we can also skip this changelog. | ||
| DataFileMeta fileMeta = writer.result(); | ||
| if (fileMeta != null) { |
Contributor
There was a problem hiding this comment.
if (fileMeta == null), extraFiles is not be deleted?
| RowType valueType, | ||
| BulkWriter.Factory<RowData> writerFactory, | ||
| @Nullable FileStatsExtractor fileStatsExtractor, | ||
| FileStatsExtractor fileStatsExtractor, |
|
|
||
| public void delete(DataFileMeta file) { | ||
| delete(file.fileName()); | ||
| public SingleFileWriter<KeyValue, Void> createExtraFileWriter() { |
Contributor
There was a problem hiding this comment.
createChangelogFileWriter? we may have more extra files in future.
JingsongLi
reviewed
Oct 8, 2022
| DataFileMeta fileMeta = writer.result(); | ||
| if (fileMeta != null) { | ||
| if (fileMeta == null) { | ||
| for (String extraFile : extraFiles) { |
Contributor
There was a problem hiding this comment.
Can we add a test for this? Maybe in ChangelogWithKeyFileStoreTableTest.testStreamingChangelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently DataFileWriter exposes write method for data files and extra files.
However, as the number of patterns to write files is increasing (for example, we'd like to write some records into a data file, then write some other records into an extra files when producing changelogs from full compaction) we'll have to keep adding methods to DataFileWriter if we keep the current implementation.
We'd like to refactor DataFileWriter into a factory to create writers, so that the users of writers can write however they like.