[FLINK-29367] FileStoreCommitImpl also checks for conflicts when committing append changes #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itting append changes
JingsongLi
reviewed
Sep 22, 2022
| } catch (Throwable e) { | ||
| throw new RuntimeException( | ||
| "File deletion conflicts detected! Give up committing compact changes.", e); | ||
| throw new RuntimeException("File deletion conflicts detected! Give up committing.", e); |
Contributor
There was a problem hiding this comment.
I think we can ignore exception from mergeManifestEntries here.
We can explain there are concurrent writing and print to change detail.
JingsongLi
reviewed
Sep 22, 2022
| readAllEntriesFromChangedPartitions( | ||
| latestSnapshotId, appendChanges, compactChanges)); | ||
| entriesToCheck.addAll(appendChanges); | ||
| noConflictsOrFail(entriesToCheck); |
Contributor
There was a problem hiding this comment.
It is better to explain in the exception: When there will be conflict and what should be done
JingsongLi
pushed a commit
that referenced
this pull request
Sep 22, 2022
…itting append changes This closes #301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the job runs to checkpoint N, if the user recovers from an old checkpoint (such as checkpoint N-5), the sink of the current FTS will cause a manifest corruption because duplicate files may be committed.
We should avoid such corruption, and the storage should be robust enough.